refactor(template): simplify tests with table-driven approach and golden files#417
Merged
refactor(template): simplify tests with table-driven approach and golden files#417
Conversation
…den files Refactor the template test file to reduce code duplication and improve maintainability: - Replace 26+ separate test functions with 3 table-driven tests - Extract expected outputs to golden files in testdata/ directory - Add helper functions for creating test fixtures - Support -update flag for easy golden file maintenance This reduces the test file from ~4,400 lines to ~280 lines while maintaining the same test coverage. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Signed-off-by: Engin Diri <engin.diri@ediri.de>
|
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
testdata/directorymakeBaseResource,makeJavaResource,makeBedrockResource) for creating test fixtures-updateflag for easy golden file maintenance when templates changeChanges
TestBashTemplates(15 test cases)TestCloudInitTemplates(11 test cases)TestConfigTemplates(5 test cases)template/testdata/*.goldenfilesloadGolden(),updateGolden(),assertGolden()Test plan
go test ./template/...)go test ./...)go vetandgo fmt🤖 Generated with Claude Code